Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oidc tenant name now properly escaped #5856

Merged

Conversation

Verdent
Copy link
Member

@Verdent Verdent commented Jan 13, 2023

Fixes #5855

Signed-off-by: David Kral <david.k.kral@oracle.com>
@Verdent Verdent self-assigned this Jan 13, 2023
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jan 13, 2023
danielkec
danielkec previously approved these changes Jan 13, 2023
Signed-off-by: David Kral <david.k.kral@oracle.com>
@klustria
Copy link
Member

I have built this change and tested both locally, remotely and remotely with proxy and validated that this fixed the OIDC issue that we observed in v2.5.5 as reported in #5855.

Copy link
Member

@klustria klustria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too

@Verdent Verdent merged commit a37798f into helidon-io:helidon-2.x Jan 16, 2023
@Verdent Verdent deleted the 5855-proper-tenant-name-escaping branch January 16, 2023 09:12
@barchetta barchetta added this to the 2.5.6 milestone Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants