-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.x.] - Deprecate MicroProfile Tracing #5909
[4.x.] - Deprecate MicroProfile Tracing #5909
Conversation
docs/mp/tracing.adoc
Outdated
@@ -39,6 +39,9 @@ include::{rootdir}/includes/mp.adoc[] | |||
|
|||
== Overview | |||
|
|||
WARNING: MicroProfile Tracing specification is discontinued. This feature is marked as `@Deprecated` in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not correct. MicroProfile OpenTracing (that is the spec name) is still there.
The OpenTracing specifciation that MP OpenTracing is based on is no longer maintained. That is the reason we are deprecating this feature.
The MP OpenTracing specification is no longer required by MicroProfile, and we (as in Helidon) have decided to deprecate it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Redefined
@@ -25,7 +25,8 @@ | |||
@Feature(value = "Tracing", | |||
description = "MicroProfile tracing spec implementation", | |||
in = HelidonFlavor.MP, | |||
path = "Tracing" | |||
path = "Tracing", | |||
since = "4.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The correct annotation structure should be:
@Feature(value = "Tracing",
description = "MicroProfile tracing spec implementation",
in = HelidonFlavor.MP,
path = "Tracing",
since = "1.0.0")
@Deprecated(since="4.0.0", forRemoval=true)
Marking this feature to be valid since version 1.0.0 to 4.0.0 and now deprecated.
If our feature processing creates wrong results, we will need to fix it - this is the intended behavior (sorry I did not explain it right when you asked about this)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed. Fixed @Deprecated
since
File handler.
Removed MP Tracing removed for bundled.
Marked for deprecation.
Resolves #5818