Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MultiPartDecoder lazy inner publisher subscription #6225

Conversation

romain-grecourt
Copy link
Contributor

  • Don't cancel the inner publisher on upstream completion if there is no subscriber
  • Report subscribe() error using method argument instead of field (field is null if not yet subscribed)

Fixes #6224

- Don't cancel the inner publisher on upstream completion if there is no subscriber
- Report subscribe() error using method argument instead of field (field is null if not yet subscribed)

Fixes helidon-io#6224
@romain-grecourt romain-grecourt self-assigned this Feb 16, 2023
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Feb 16, 2023
@romain-grecourt romain-grecourt added this to the 3.1.3 milestone Feb 16, 2023
@romain-grecourt romain-grecourt merged commit a07ebcb into helidon-io:helidon-3.x Feb 16, 2023
@romain-grecourt romain-grecourt deleted the multipart-decoder-lazy-part-content-subscribe-3.x branch February 16, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[3.x] MultiPartDecoder lazy part content subscription
2 participants