Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nima custom archetype #6327

Merged
merged 6 commits into from
Jul 14, 2023
Merged

Conversation

tvallin
Copy link
Member

@tvallin tvallin commented Mar 1, 2023

fix #6243

@tvallin tvallin requested a review from romain-grecourt March 1, 2023 15:34
@tvallin tvallin self-assigned this Mar 1, 2023
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Mar 1, 2023
@tvallin tvallin force-pushed the nima_custom_archetype branch from 0ed71a0 to a7cb7c1 Compare June 5, 2023 15:20
@tvallin tvallin force-pushed the nima_custom_archetype branch from 305f231 to 2c0e442 Compare July 11, 2023 08:11
tvallin added 4 commits July 13, 2023 09:31
Signed-off-by: tvallin <thibault.vallin@oracle.com>
Signed-off-by: tvallin <thibault.vallin@oracle.com>
Signed-off-by: tvallin <thibault.vallin@oracle.com>
Signed-off-by: tvallin <thibault.vallin@oracle.com>
@tvallin tvallin force-pushed the nima_custom_archetype branch from ba27be1 to 6a82adf Compare July 13, 2023 13:47
Signed-off-by: tvallin <thibault.vallin@oracle.com>
Copy link
Member

@barchetta barchetta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple things:

  1. The READMEs say "JDK19+". Should say "JDK20"
  2. quickstart-nima and custom-nima: the WebServer starts on a random port because application.yaml is not getting picked up. Had to add helidon-config-yaml to dependencies, and code to load config:
        Config config = Config.create();
        WebServer server = WebServer.builder()
                .config(config.get("server"))
                . . .
  1. PR Fix archetype build #7177 broke CLI version 3.0.4. Can you fix the archetype build so that it creates both versions.xml AND cli-data/latest ? That way the archetype build works with either 3.0.4 or 3.0.5 CLI.

Signed-off-by: tvallin <thibault.vallin@oracle.com>
Copy link
Member

@barchetta barchetta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@barchetta barchetta merged commit 439fd79 into helidon-io:main Jul 14, 2023
@tvallin tvallin deleted the nima_custom_archetype branch July 14, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
archetypes OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants