-
Notifications
You must be signed in to change notification settings - Fork 579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nima custom archetype #6327
Merged
Merged
Nima custom archetype #6327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
All contributors have signed the Oracle Contributor Agreement.
label
Mar 1, 2023
tvallin
force-pushed
the
nima_custom_archetype
branch
from
June 5, 2023 15:20
0ed71a0
to
a7cb7c1
Compare
tvallin
force-pushed
the
nima_custom_archetype
branch
from
July 11, 2023 08:11
305f231
to
2c0e442
Compare
Signed-off-by: tvallin <thibault.vallin@oracle.com>
Signed-off-by: tvallin <thibault.vallin@oracle.com>
tvallin
force-pushed
the
nima_custom_archetype
branch
from
July 13, 2023 13:47
ba27be1
to
6a82adf
Compare
Signed-off-by: tvallin <thibault.vallin@oracle.com>
barchetta
requested changes
Jul 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple things:
- The READMEs say "JDK19+". Should say "JDK20"
- quickstart-nima and custom-nima: the WebServer starts on a random port because
application.yaml
is not getting picked up. Had to addhelidon-config-yaml
to dependencies, and code to load config:
Config config = Config.create();
WebServer server = WebServer.builder()
.config(config.get("server"))
. . .
- PR Fix archetype build #7177 broke CLI version 3.0.4. Can you fix the archetype build so that it creates both
versions.xml
ANDcli-data/latest
? That way the archetype build works with either 3.0.4 or 3.0.5 CLI.
Signed-off-by: tvallin <thibault.vallin@oracle.com>
barchetta
approved these changes
Jul 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #6243