Do not split headers and payload into two different buffers #6491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… may result in a drop in performance if no-tcp-delay is false and client uses delayed ACKs. Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
oracle-contributor-agreement
bot
added
the
OCA Verified
This was referenced Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing so may result in a drop in performance if no-tcp-delay is false (i.e. Nagle's algorithm is enabled) and client uses delayed ACKs (normally enabled). This draft also includes calls to listener (were absent) and verifies we don't exceed content length while writing the first payload part.
Writing two or more small buffers in sequence hits a problematic interaction between Nagle's algorithm and ACK delays in TCP that will cause a long delay where both ends are waiting for each other for 40 ms at least. This affects latency and throughput.