All Pico services should default to a lesser than DEFAULT_WEIGHT #6590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
tomas-langer
requested changes
Apr 12, 2023
| */ | ||
| double DEFAULT_WEIGHT = Weighted.DEFAULT_WEIGHT; | ||
| double DEFAULT_PICO_WEIGHT = Weighted.DEFAULT_WEIGHT; |
There was a problem hiding this comment.
I do not see the -1 mentioned in the javadoc
|
|
||
| /** | ||
| * Service-loaded provider for {@link io.helidon.builder.config.spi.ConfigResolverProvider}. | ||
| */ | ||
| @Weight(Weighted.DEFAULT_WEIGHT) | ||
| @Weight(io.helidon.pico.api.ServiceInfoBasics.DEFAULT_PICO_WEIGHT) |
There was a problem hiding this comment.
Why is it fully qualified? There should not be a naming conflict.
There was a problem hiding this comment.
Yes, it was just easier to do it that way. Is that somehow a problem? I did the same for the javadoc.
There was a problem hiding this comment.
In Javadoc, you should use fully qualified. In code, only when you have conflicting types
…ride default behaviors)
tomas-langer
requested changes
Apr 13, 2023
|
|
||
| /** | ||
| * Service-loaded provider for {@link io.helidon.builder.config.spi.ConfigResolverProvider}. | ||
| */ | ||
| @Weight(Weighted.DEFAULT_WEIGHT) | ||
| @Weight(io.helidon.pico.api.ServiceInfoBasics.DEFAULT_PICO_WEIGHT) |
There was a problem hiding this comment.
In Javadoc, you should use fully qualified. In code, only when you have conflicting types
tomas-langer
approved these changes
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue#6583.