Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily remove examples generated by OpenAPITools #6667

Merged
merged 1 commit into from
Apr 21, 2023

Conversation

tjquinno
Copy link
Member

@tjquinno tjquinno commented Apr 20, 2023

Resolves #5850

If you run the OpenAPITools Helidon generators and specify helidonVersion as 4.0.0-ALPHA6 the generator runs to completion without error. In fact, Arjav has shown that generating the Java code into an existing project yields correct code for MP.

But if you use the generators to create new projects, the generator completes but the resulting project does not build. The generated logging.properties file refers to the Helidon logging handler in its 3.x package which is different in 4.x.

To avoid confusion, this PR removes the examples until we update the generators and regenerate the example projects.

We will replace the examples with code created by the updated generator once we have that.

…te the generators and regenerate the example projects
@tjquinno tjquinno self-assigned this Apr 20, 2023
@tjquinno tjquinno linked an issue Apr 20, 2023 that may be closed by this pull request
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Apr 20, 2023
@tjquinno tjquinno merged commit 2dc9912 into helidon-io:main Apr 21, 2023
@tjquinno tjquinno deleted the 4.x-openapi-gen-examples-fix branch April 21, 2023 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4.x: examples/openapi-tools references Helidon 3.0.1
2 participants