Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GeneratedConfigBean should be easily available from Config-driven-services #6680

Merged
merged 4 commits into from
Apr 25, 2023

Conversation

trentjeff
Copy link
Member

This is a pre-req to issue #6674

@trentjeff trentjeff added the declarative Helidon Declarative label Apr 24, 2023
@trentjeff trentjeff self-assigned this Apr 24, 2023
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Apr 24, 2023
*/
void __instanceId(String val);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: The setter was taken out of this interface and pushed down to the abstract impl.

@@ -67,6 +67,10 @@ static void internalMetaAttributes(StringBuilder builder) {
builder.append("\tpublic static Map<String, Map<String, Object>> __metaAttributes() {\n"
+ "\t\treturn ").append(BodyContext.TAG_META_PROPS).append(";\n"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: unfortunately we still need the static approach for other use cases.

@trentjeff trentjeff merged commit d130dce into helidon-io:main Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
declarative Helidon Declarative OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants