Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] - Fix LRA Logging #6733

Merged
merged 2 commits into from
May 3, 2023
Merged

[3.x] - Fix LRA Logging #6733

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
70bafc3
Fix 6720 LRA Logging
dalexandrov May 2, 2023
0f5122a
Remove redundant check
dalexandrov May 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions ...ayana-client/src/main/java/io/helidon/lra/coordinator/client/narayana/NarayanaClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2021, 2022 Oracle and/or its affiliates.
* Copyright (c) 2021, 2023 Oracle and/or its affiliates.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -145,11 +145,9 @@ public Single<Void> cancel(URI lraId, PropagatedHeaders headers) {
logF("LRA cancelled - LRAID: {0}", lraId);
return Single.empty();
case CLIENT_ERROR:
logF("Unexpected client error during LRA cancel - LRAID: {0}, Status: {1}", lraId, status.code());
return Single.empty();
default:
if (404 == status.code()) {
LOGGER.warning("Cancel LRA - Coordinator can't find id - LRAID: " + lraId);
return Single.empty();
}
return connectionError("Unable to cancel lra " + lraId, status.code());
}
})
Expand Down