Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x]: Fix params of @ExampleObject annotations in examples (#6040) #6782

Merged
merged 2 commits into from
May 8, 2023

Conversation

Captain1653
Copy link
Contributor

@Captain1653 Captain1653 commented May 7, 2023

Fixes #6040

  • Create backport 2.x

I've found only this ExampleObject-annotation. There is no anymore. Also, I changed the schema, because it was wrong as I can see.

I'm not sure about syntax "{\"greeting\": \"New greeting message\""))) in the docs.

Kind regards

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label May 7, 2023
@romain-grecourt romain-grecourt requested a review from tjquinno May 7, 2023 18:37
Copy link
Member

@tjquinno tjquinno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the example JSON syntax.

@Captain1653 Captain1653 requested a review from tjquinno May 8, 2023 14:27
@tjquinno tjquinno merged commit 0271285 into helidon-io:helidon-3.x May 8, 2023
@Captain1653 Captain1653 deleted the 6040-change-example branch May 9, 2023 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review OpenAPI annotations in our examples for correct example value format
2 participants