Creates a clean set of Pico examples #6800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
|
Disregard the changes under /pico as that will be merged in from #6801 and then we will rebase over that here. |
trentjeff
requested review from
tjquinno,
barchetta,
ljnelson,
spericas,
arjav-desai,
danielkec and
ljamen
barchetta
reviewed
May 12, 2023
dalexandrov
reviewed
May 19, 2023
examples/pico/basics/src/main/java/io/helidon/examples/pico/basics/ToolBox.java
Outdated
Show resolved
Hide resolved
examples/pico/configdriven/src/main/java/io/helidon/examples/pico/configdriven/Main.java
Outdated
Show resolved
Hide resolved
examples/pico/interceptors/src/main/java/io/helidon/examples/pico/interceptors/Main.java
Outdated
Show resolved
Hide resolved
spericas
reviewed
May 19, 2023
|
|
||
| .level = INFO | ||
| io.helidon.config.level = WARNING | ||
| io.helidon.config.examples.level = FINEST |
There was a problem hiding this comment.
Is this logging setting being used?
There was a problem hiding this comment.
I thought this was a convention, looking at some other examples. It is not needed directly by my examples, no. Do you therefore suggest to remove them?
spericas
reviewed
May 19, 2023
examples/pico/providers/src/main/java/io/helidon/examples/pico/providers/AngleGrinderSaw.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pre-req changes have been extracted from this into its own PR.
Will resolve #6776