-
Notifications
You must be signed in to change notification settings - Fork 579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft of the integration doc for 3.x #6864
Draft of the integration doc for 3.x #6864
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is ready for dev review. I will do another review after all comments have been addressed (prior to release)
Do we document helidon.serialFilter.pattern must be set, and how it should be set? |
Is this what you are asking about, @edbratt? https://helidon.io/docs/latest/apidocs/io.helidon.common/io/helidon/common/SerializationConfig.html |
Yes. I believe there are certain signatures that are required for at least some of the scenarios. |
docs/mp/integrations/wls.adoc
Outdated
|
||
== Overview | ||
|
||
The Oracle WebLogic Server and Helidon integration enables interaction between a Helidon microservice application and an application installed on Oracle WebLogic Server, which is deployed in a Kubernetes cluster managed by the WebLogic Kubernetes Operator (WKO). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This statement is too restrictive. Kubernetes/Kubernetes Operator, etc. are not always required. I believe the language in the WLS docs says: "This document provides information about the Oracle WebLogic Server and Helidon integration when both products are deployed in a Kubernetes environment. However, you can implement this integration on any supported platform." (I added the bold text which may be sufficient)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will update this statement.
Hi @edbratt which signatures are required? We will need to document those. |
docs/mp/integrations/wls.adoc
Outdated
|
||
=== Usage [[REST-Services-Usage]] | ||
|
||
After you add the dependencies, you can build the Helidon client and invoke the Oracle WebLogic Web Service by compiling the Helidon client using Maven. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No he can't there is no actual code in this example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's why I've suggested to stick with a project generated by CLI or Project Starter.
docs/mp/integrations/wls.adoc
Outdated
{wls-thin-link} can be obtained from multiple sources. | ||
Legacy versions of thin client can be found in server/lib directory(`WL_HOME/server/lib/wlthint3client.jar`) of any WebLogic Server installation. | ||
|
||
WARNING: Helidon supports {jakarta-version} and legacy versions of `javax` based thin T3 client wouldn't work correctly when on it's classpath. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please review English of this warning. I believe something like the following will be more clear:
Warning: Helidon supports {jakarta-version}. Previous versions of Java EE which use object with 'javax' class signatures will not work directly. Placing a 'javax' version of the T3 Thin client onto the Helidon-service class path will not work. For proper integration, the 'javax' version of T3 Thin client must be used, only with specialized xref:../../mp/reactivemessaging/weblogic.adoc[WebLogic JMS Connector].
docs/mp/integrations/wls.adoc
Outdated
<4> JMS environment properties to lookup resources | ||
<5> Destination with `jndi.` prefix is evaluated as JNDI name, simple `destination` is evaluated as a CDI syntax | ||
|
||
For more detailed reading about Reactive Messaging configuration see xref:../../mp/reactivemessaging/introduction.adoc#_configuration[Reactive Messaging Configuration]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please consider adding a x-ref to the WLS documentation that describes how to obtain the WL-JMS specific values.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Geetha-Savithriamma I did a very quick review of the text. Please incorporate into the docs.
docs/includes/security/jep-290.adoc
Outdated
<5> Configure this serialization config as the default for this JVM | ||
|
||
== JEP-290 Pattern syntax |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Syntax (cap init) also make this change in the TOC above
docs/includes/security/jep-290.adoc
Outdated
@@ -100,4 +102,60 @@ SerializationConfig.builder() | |||
<2> Configure a single class filter pattern (only allows deserialization of class `MyType` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
of class `MyType)
docs/includes/security/jep-290.adoc
Outdated
<5> Configure this serialization config as the default for this JVM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
serialization pattern (can we use the word pattern instead of repeating config?)
docs/includes/security/jep-290.adoc
Outdated
|
||
== Troubleshooting | ||
Helidon serialization config filter doesn't trace actual rejected classes by default. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Helidon ...
docs/includes/security/jep-290.adoc
Outdated
== Troubleshooting | ||
Helidon serialization config filter doesn't trace actual rejected classes by default. | ||
All you are going to find in the logs is InvalidClassException with message `filter status: REJECTED`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The log files will only show InvalidClassException with message filter status: REJECTED
.
|
||
Connecting to WebLogic JMS connection factories requires proprietary T3 thin client library which can be obtained from | ||
WebLogic installation. | ||
Helidon supports {jakarta-version} and legacy versions of `javax` based thin T3 client wouldn't work correctly when on it's classpath. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Helidon supports {jakarta-verion}, Legacy versions of javax
-based thin T3 clients will not work when added to the classpath. Legacy thin T3 clients must be loaded from a filesystem location specified by the thin-jar
property.
|
||
WARNING: Avoid placing `wlthint3client.jar` on Helidon classpath, client library location needs to be | ||
WARNING: Avoid placing legacy `wlthint3client.jar` on Helidon classpath, client library location needs to be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not include legacy wlthint3client.jar
on the Helidon classpath. The client library needs to be configured and loaded by the Helidon messaging connector.
configured and loaded by Helidon messaging connector. | ||
|
||
WARNING: Don't forget to start your Helidon app with `--add-opens=java.base/java.io=ALL-UNNAMED` to allow | ||
WARNING: Don't forget to start your Helidon app with `--add-opens=java.base/java.io=ALL-UNNAMED` to allow legacy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When using legacy WebLogic T3 thin clients, make sure to start the Helidon application with [...] to allow reflection with the wlthint3client
.
wlthint3client use reflection. | ||
|
||
Updated version of thin T3 client compatible with modern Jakarta runtimes can be downloaded from {osdc-link} as `wlthint3client.jakarta`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated versions of the thin T3 client, that are compatible with modern Jakarata runtimes, can be downloaded from ....
wlthint3client use reflection. | ||
|
||
Updated version of thin T3 client compatible with modern Jakarta runtimes can be downloaded from {osdc-link} as `wlthint3client.jakarta`. | ||
Jakarta based thin client can be placed on Helidon classpath and used with this specialized connector or |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Jakarta-based thin clients, however, can be placed on the Helidon classpath and used with this specialized connector or the [...].
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 30 - change URL for prod. It is set to UAT.
The following integrations are included: REST JMS Web Services SSO
a608885
to
4de5ffb
Compare
This is the first draft. The following integrations are included:
Please review.