-
Notifications
You must be signed in to change notification settings - Fork 580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TCK Tracking: Jakarta EE 10 Core Profile #6799 #6885
Conversation
d4388af
to
f0575ea
Compare
b544b81
to
2137152
Compare
bc398bc
to
56ac1ee
Compare
b2a3cb1
to
a43f028
Compare
4a370f1
to
2fdbf2c
Compare
e410f16
to
b1d4d2a
Compare
This PR is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a few .sh
files in the PR, with no explanation in a README.md or simillar - do we need those files? If we do, why and how should we use them?
Any shell script is a danger for us - we need to maintain them, and if called from aynwhere in maven (or ant that was added), it may do things that are unexpected.
...-cdi/src/test/java/org/jboss/cdi/tck/tests/policy/broken/incorrect/name/stereotype/Mock.java
Outdated
Show resolved
Hide resolved
...oprofile/tests/tck/tck-restfull/tck-restfull-test/src/test/resources/logging-test.properties
Outdated
Show resolved
Hide resolved
These sh and ant scripts exists because TCK artifacts don't exist in any maven repository. They submit a zip file with the jars, and sometimes there is an SH file to install dependencies. I think there is no need for READMEs because nobody is supposed to understand and execute that. They are executed as a part of the maven ant plugin. |
b3e3aa2
to
97f9daf
Compare
I added the readmes for the sh files |
0fc22ff
to
881fb57
Compare
...oprofile/tests/tck/tck-restfull/tck-restfull-test/src/test/resources/logging-test.properties
Outdated
Show resolved
Hide resolved
6191844
to
99d1b6a
Compare
Signed-off-by: Jorge Bescos Gascon <jorge.bescos.gascon@oracle.com>
TCK Inject failed because I changed the visibility of I have deleted that class and loaded it from the one that exists in |
Relates to #6799
Some TCK tests are excluded in restfull and cdi. You can see them with a
<!-- FIXME: Next tests must be enabled -->
in the pom file. I will create a new issue to address that.URL of the TCKS:
https://download.eclipse.org/ee4j/jakartaee-tck/jakartaee10/promoted/eftl/