Nima WebClient configuration for timeouts and keepAlive

[aserkes]

Fixes #6961
Fixes #6979

[romain-grecourt]

Here is what can be done with the reactive WebClient in 3.x and 2.x :

WebClient client = WebClient.builder()
                            .connectTimeout(30, TimeUnit.SECONDS)
                            .readTimeout(10, TimeUnit.SECONDS)
                            .build();

WebClientResponse response = client.get()
                                   .connectTimeout(30, TimeUnit.SECONDS)
                                   .readTimeout(10, TimeUnit.SECONDS)
                                   .submit()
                                   .await();

Here is some Nima based code:

Http1Client client =
        Http1Client.builder()
                   .channelOptions(SocketOptions
                           .builder()
                           .connectTimeout(Duration.ofSeconds(30))
                           .readTimeout(Duration.ofSeconds(10))
                           .build())
                   //.connectTimeout(Duration.ofSeconds(30)) <-- shortcut
                   //.readTimeout(Duration.ofSeconds(10))    <-- shortcut
                   .build();
Http1ClientResponse response = client.get()
                                     //.connectTimeout(Duration.ofSeconds(30))  <-- if possible
                                     //.readTimeout(Duration.ofSeconds(10))     <-- if possible
                                     .request();

The commented out code above is what needs to be implemented.

[aserkes]

If I understand it correctly, these timeouts related to the timeouts from SocketOptions. Therefore, to add the shortcuts and make these timeouts consistent with the timeouts from SocketOptions, as an option, I need to change SocketOptions and add a getter for socketOptions field in this class. Is it possible to change SocketOptions?

[romain-grecourt]

Here are some rough steps

• Add a new field to WebClient.Builder: SocketOptions.Builder channelOptionsBuilder.
• In WebClient.Builder.build() if channelOptions is null, then assign a value using channelOptionsBuilder.build()
• Update LoomClient constructor to remove the null check since channelOptionsBuilder is now never null
• Add the following methods to WebBuilder.Builder:

public B readTimeout(Duration readTimeout) {
    this.channelOptionsBuilder.readTimeout(readTimeout);
    return (B) this;
}

public B connectTimeout(Duration connectTimeout) {
    this.channelOptionsBuilder.connectTimeout(connectTimeout);
    return (B) this;
}