[4.x] Avoid reflecting back user data in exception messages #6990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
… flag in RequestException that can be used to control when it is safe to include a message in a response entity and when it is not. It is by default set to true (safe) but is now set to false in Http1Prologue to avoid data leaks. New test added. See issue helidon-io#6986.
barchetta
approved these changes
Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid reflecting back user data in exception messages. There is a new flag in RequestException that can be used to control when it is safe to include a message in a response entity and when it is not. It is by default set to true (safe) but is now set to false in Http1Prologue to avoid data leaks. New test added. See issue #6986.