Issue #6774 - WebClient should have a mode that is resilient to bad media/content types #6999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
…t to bad media/content types Signed-off-by: Tomáš Kraus <tomas.kraus@oracle.com>
tomas-langer
requested changes
Jun 15, 2023
common/http/src/main/java/io/helidon/common/http/Http1HeadersParser.java
Outdated
Show resolved
Hide resolved
common/http/src/main/java/io/helidon/common/http/Http1HeadersParser.java
Outdated
Show resolved
Hide resolved
common/media-type/src/main/java/io/helidon/common/media/type/MediaTypeImpl.java
Outdated
Show resolved
Hide resolved
common/media-type/src/main/java/io/helidon/common/media/type/ParserMode.java
Outdated
Show resolved
Hide resolved
common/media-type/src/main/java/io/helidon/common/media/type/ParserMode.java
Outdated
Show resolved
Hide resolved
trentjeff
reviewed
Jun 15, 2023
common/http/src/main/java/io/helidon/common/http/Http1HeadersParser.java
Outdated
Show resolved
Hide resolved
common/media-type/src/main/java/io/helidon/common/media/type/MediaTypeImpl.java
Outdated
Show resolved
Hide resolved
common/media-type/src/main/java/io/helidon/common/media/type/ParserMode.java
Outdated
Show resolved
Hide resolved
common/media-type/src/main/java/io/helidon/common/media/type/ParserMode.java
Outdated
Show resolved
Hide resolved
nima/http/media/multipart/src/main/java/io/helidon/nima/http/media/multipart/MultiPartImpl.java
Outdated
Show resolved
Hide resolved
...ttp/media/multipart/src/main/java/io/helidon/nima/http/media/multipart/MultiPartSupport.java
Outdated
Show resolved
Hide resolved
nima/webclient/webclient/src/main/java/io/helidon/nima/webclient/http1/ClientResponseImpl.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Tomáš Kraus <tomas.kraus@oracle.com>
Signed-off-by: Tomáš Kraus <tomas.kraus@oracle.com>
trentjeff
previously approved these changes
Jun 15, 2023
tomas-langer
requested changes
Jun 15, 2023
common/media-type/src/main/java/io/helidon/common/media/type/ParserMode.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Tomáš Kraus <tomas.kraus@oracle.com>
tomas-langer
approved these changes
Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added relaxed mode to media type parser in media type and http modules of common.
This affects how HTTP1 headers are being parsed:
text->text/plainto resolve issue [4.x] WebClient should have a mode that is resilient to bad media/content types #6774.