[3.x] - Make Zipkin baggage aware #7004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
tomas-langer
requested changes
Jun 20, 2023
| public static final String VALUE = "1"; | ||
|
|
||
| @BeforeAll | ||
| static void startTheServer() { |
There was a problem hiding this comment.
wrong method name
also you do not need to do this in a before all, when you have a single test method.
Even if you do, do not register the tracer as global, as that may conflict with other tests. It is better to create a tracer and store it in a field (or just local variable within a test).
Signed-off-by: Dmitry Aleksandrov <dmitry.aleksandrov@oracle.com>
tomas-langer
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6997