Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TLS reloading fixed #7140

Merged
merged 2 commits into from
Jul 2, 2023
Merged

TLS reloading fixed #7140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
79c2762
TLS reloading fix
Verdent Jun 30, 2023
4984572
TLS reload test enabled
Verdent Jun 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .../webserver/mtls/src/test/java/io/helidon/nima/tests/integration/server/mtls/MtlsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,6 @@ void testMutualTlsCertificates() {
}

@Test
@Disabled
void testTlsReload() {
Http1ClientResponse response = client.method(Http.Method.GET)
.uri("/serverCert")
Expand Down
2 changes: 1 addition & 1 deletion nima/webserver/webserver/src/main/java/io/helidon/nima/webserver/ServerListener.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,7 +312,7 @@ void reloadTls(Tls tls) {
if (!tls.enabled()) {
throw new UnsupportedOperationException("TLS cannot be disabled by reloading on the socket " + socketName);
}
tls.reload(tls);
this.tls.reload(tls);
}

private void debugTls(String serverChannelId, Tls tls) {
Expand Down