Class model and builder generation reworked #7256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
Verdent
force-pushed
the
6716-class-model
branch
2 times, most recently
from
b3b0444 to
69135ab
Compare
trentjeff
suggested changes
Aug 8, 2023
builder/processor/src/main/java/io/helidon/builder/processor/BlueprintProcessor.java
Outdated
Show resolved
Hide resolved
builder/processor/src/main/java/io/helidon/builder/processor/BlueprintProcessor.java
Show resolved
Hide resolved
builder/processor/src/main/java/io/helidon/builder/processor/BlueprintProcessor.java
Show resolved
Hide resolved
builder/processor/src/main/java/io/helidon/builder/processor/BlueprintProcessor.java
Outdated
Show resolved
Hide resolved
builder/processor/src/main/java/io/helidon/builder/processor/GenerateAbstractBuilder.java
Outdated
Show resolved
Hide resolved
builder/tests/common-types/src/main/java/io/helidon/common/types/TypeNameBlueprint.java
Outdated
Show resolved
Hide resolved
common/processor/class-model/src/main/java/io/helidon/common/processor/model/ClassType.java
Outdated
Show resolved
Hide resolved
trentjeff
previously approved these changes
Aug 14, 2023
tomas-langer
requested changes
Aug 14, 2023
| @@ -253,331 +259,223 @@ private void generatePrototypeWithBuilder(TypeElement builderInterface, | |||
| TypeInfo typeInfo = typeInformation.blueprintType(); | |||
| TypeName prototype = typeContext.typeInfo().prototype(); | |||
| String ifaceName = prototype.className(); | |||
| List<TypeName> typeGenericArguments = blueprintDef.typeArguments(); | |||
There was a problem hiding this comment.
See line 243 (original), 249 (new):
@SuppressWarnings("checkstyle:MethodLength") // will be fixed when we switch to model
builder/processor/src/main/java/io/helidon/builder/processor/TypeHandler.java
Show resolved
Hide resolved
common/processor/class-model/src/main/java/io/helidon/common/processor/model/Method.java
Outdated
Show resolved
Hide resolved
common/types/src/main/java/io/helidon/common/types/Annotation.java
Outdated
Show resolved
Hide resolved
common/types/src/main/java/io/helidon/common/types/Annotation.java
Outdated
Show resolved
Hide resolved
Signed-off-by: David Kral <david.k.kral@oracle.com>
Signed-off-by: David Kral <david.k.kral@oracle.com>
Signed-off-by: David Kral <david.k.kral@oracle.com>
Signed-off-by: David Kral <david.k.kral@oracle.com>
Signed-off-by: David Kral <david.k.kral@oracle.com>
Signed-off-by: David Kral <david.k.kral@oracle.com>
Signed-off-by: David Kral <david.k.kral@oracle.com>
Signed-off-by: David Kral <david.k.kral@oracle.com>
Signed-off-by: David Kral <david.k.kral@oracle.com>
Signed-off-by: David Kral <david.k.kral@oracle.com>
Signed-off-by: David Kral <david.k.kral@oracle.com>
Signed-off-by: David Kral <david.k.kral@oracle.com>
Signed-off-by: David Kral <david.k.kral@oracle.com>
Signed-off-by: David Kral <david.k.kral@oracle.com>
Signed-off-by: David Kral <david.k.kral@oracle.com>
Signed-off-by: David Kral <david.k.kral@oracle.com>
Verdent
force-pushed
the
6716-class-model
branch
from
76afdca to
867d050
Compare
Signed-off-by: David Kral <david.k.kral@oracle.com>
tomas-langer
approved these changes
Aug 16, 2023
This was referenced Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6713
Fixes #6716