Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prototype builder update #7281

Merged
merged 4 commits into from
Aug 1, 2023
Merged

Prototype builder update #7281

merged 4 commits into from
Aug 1, 2023

Conversation

tomas-langer
Copy link
Member

@tomas-langer tomas-langer commented Jul 31, 2023 •
edited
Loading

Fixes #7212
Fixes #7283

Also changed interceptor to decorator, as interceptor not needed for builders

@tomas-langer tomas-langer self-assigned this Jul 31, 2023
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jul 31, 2023
@tomas-langer tomas-langer added 4.x Version 4.x builder Related to the builder support and removed OCA Verified All contributors have signed the Oracle Contributor Agreement. labels Jul 31, 2023
@tomas-langer tomas-langer mentioned this pull request Jul 31, 2023
Closed
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jul 31, 2023
@tomas-langer
- builder getters use Optional where can be null
8f3fe8a 
- builder no longer implements prototype
- interceptor changed to decorator
@tomas-langer
- prototype builder no longer implements prototype
1ec4efd 
- builder methods now return Optional where appropriate
- builder interceptor now a decorator
@tomas-langer
Fixed builder usage
633b19d
@tomas-langer tomas-langer force-pushed the 7212-prototype-builder branch from 1a5c15a to 633b19d Compare July 31, 2023 21:09
@tomas-langer
Copy link
Member Author

Rebased on main

@tomas-langer tomas-langer mentioned this pull request Jul 31, 2023
Closed
16 tasks
romain-grecourt
romain-grecourt reviewed Jul 31, 2023
View reviewed changes
Copy link
Contributor

@romain-grecourt romain-grecourt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The following does not compile anymore.

WebServer.builder().mediaContext(MediaContext.builder());

The builder should have a variant of the mediaContext method that accepts Supplier<MediaContext>.

@tomas-langer
Copy link
Member Author

I would prefer to add the methods that accept supplier as a follow up to this issue. This is fixing the problem of sending builder where we should have sent a built value.

@helidon-io helidon-io deleted a comment from tomas-langer Aug 1, 2023
@tomas-langer tomas-langer merged commit 6153086 into helidon-io:main Aug 1, 2023
@tomas-langer tomas-langer deleted the 7212-prototype-builder branch August 1, 2023 10:34
@tjquinno tjquinno mentioned this pull request Aug 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romain-grecourt romain-grecourt romain-grecourt approved these changes

@trentjeff trentjeff Awaiting requested review from trentjeff

@danielkec danielkec Awaiting requested review from danielkec

@Verdent Verdent Awaiting requested review from Verdent

Assignees

@tomas-langer tomas-langer

Labels
4.x Version 4.x builder Related to the builder support OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomas-langer @romain-grecourt