4.x: Enables OIDC integration tests and fixes a couple of problems in WebClient #7390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent: 1. In ClientUri, UriQueryWriteable is initialized from a decoded string. If initialized using an encoded string as before, a second encoding will take place internally. 2. The WebClientCookieManager now correctly handles cookie values, including those that may contain commas (such as expiration values). There are new or updated tests to cover the changes in (1) and (2).
oracle-contributor-agreement
bot
added
the
OCA Verified
tomas-langer
changed the title
tomas-langer
approved these changes
Aug 17, 2023
Verdent
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enables OIDC integration tests. Fixes two additional issues in WebClient:
There are new or updated tests to cover the changes in (1) and (2). Issue #7120.
Documentation
None