4.x: Allowed values are now checked when validating a builder. #7400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
Verdent
requested changes
Aug 18, 2023
builder/processor/src/main/java/io/helidon/builder/processor/GenerateAbstractBuilder.java
Outdated
Show resolved
Hide resolved
builder/processor/src/main/java/io/helidon/builder/processor/PrototypeProperty.java
Outdated
Show resolved
Hide resolved
.../processor/processor/src/main/java/io/helidon/common/processor/ToAnnotationValueVisitor.java
Outdated
Show resolved
Hide resolved
common/types/src/main/java/io/helidon/common/types/Annotation.java
Outdated
Show resolved
Hide resolved
common/types/src/main/java/io/helidon/common/types/Annotation.java
Outdated
Show resolved
Hide resolved
trentjeff
suggested changes
Aug 18, 2023
| @@ -52,7 +52,7 @@ interface MyConfigBeanBlueprint { | |||
| */ | |||
| @ConfiguredOption(key = "port", value = "8080", allowedValues = { | |||
| @ConfiguredValue(value = "8080", description = "t1"), | |||
| @ConfiguredValue(value = "false", description = "t2")}) | |||
| @ConfiguredValue(value = "80", description = "t2")}) | |||
There was a problem hiding this comment.
what is really needed here is a range of good values. I think ultimately for this we need to refer to a method or class to instantiate to perform dynamic validations for complex cases.
There was a problem hiding this comment.
false is never a good value for an integer port. Not sure what you mean by this. If you need better validation, you can always have a custom decorator
.../oci/sdk/runtime/src/test/java/io/helidon/integrations/oci/sdk/runtime/OciExtensionTest.java
Show resolved
Hide resolved
Verdent
approved these changes
Aug 21, 2023
trentjeff
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using
@ConfiguredOption(allowedValues=...)the generated builders now validate (during build) that the option is within the allowed values.null, a check is made of itsString.valueOf()against the String allowed value setThis change required modifying
Annotationto support typed values and nested annotations, this has been done as well.Documentation
This enhancement enforces an existing API in
ConfiguredOption.Annotation now supports nested annotations and typed values. Methods to obtain a typed value are now added to the
Annotationtype (inhelidon-common-types)Resolves #6403
Resolves #6231