-
Notifications
You must be signed in to change notification settings - Fork 579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCS: SE Diffs 3.x to Main *.adoc #7515
Conversation
@@ -1,6 +1,6 @@ | |||
/////////////////////////////////////////////////////////////////////////////// | |||
|
|||
Copyright (c) 2023 Oracle and/or its affiliates. | |||
Copyright (c) 2020, 2023 Oracle and/or its affiliates. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No changes in file?
@@ -1,6 +1,6 @@ | |||
/////////////////////////////////////////////////////////////////////////////// | |||
|
|||
Copyright (c) 2019, 2022 Oracle and/or its affiliates. | |||
Copyright (c) 2019, 2023 Oracle and/or its affiliates. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only date changed?
@@ -66,7 +71,7 @@ The rest of this section takes you through the process of changing your applicat | |||
. Register an instance of link:{micrometer-javadoc-base-url}/io/helidon/integrations/micrometer/MicrometerSupport.html[`MicrometerSupport`] with the web server. | |||
. Create meters using the meter registry managed by Helidon's `MicrometerSupport` and then update and query those meters. | |||
|
|||
=== Register an Instance of `MicrometerSupport` with the Web Server | |||
=== Register an Instance of MicrometerSupport with the Web Server |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not keep in ``?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then just split the word?
@@ -127,7 +133,7 @@ You can override these defaults in either of two ways: | |||
* Using the link:{micrometer-javadoc-base-url}/io/helidon/integrations/micrometer/MicrometerSupport.Builder.html[`MicrometerSupport.Builder`] class | |||
* Using configuration | |||
|
|||
==== Using `MicrometerSupport.Builder` | |||
==== Using MicrometerSupport.Builder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as everywhere in the file for code in headers
@@ -156,7 +162,7 @@ MicrometerSupport support = MicrometerSupport.builder() | |||
include::{rootdir}/includes/metrics/micrometer-shared.adoc[tag=overriding-using-config] | |||
|
|||
|
|||
=== Enrolling other Micrometer meter registries | |||
=== Enrolling Other Micrometer Meter Registries |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"O"ther?
Description
This PR will capture all of the diffs from 3.x to main in se/docs.
Each commit will reference a different adoc.
Once merged I will update the 4x doc issues indicating that the docs have been updated for diffs.