[3.x] - Migrate opentracing to Helidon Tracing #7709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dmitry Aleksandrov <dmitry.aleksandrov@oracle.com>
oracle-contributor-agreement
bot
added
the
OCA Verified
tomas-langer
requested changes
Oct 4, 2023
| } | ||
| Tags.COMPONENT.set(span, "dbclient"); | ||
| Tags.DB_TYPE.set(span, serviceContext.dbType()); | ||
| Tag.COMPONENT.create("dbclient").apply(span); |
There was a problem hiding this comment.
the part Tag.COMPONENT.create("dbclient") should be done just once and stored in a constant, there is no need to re-create it for every reported span
| Tags.ERROR.set(span, Boolean.TRUE); | ||
| span.log(Map.of("event", "error", | ||
| "error.kind", "Exception", | ||
| Tag.ERROR.create(Boolean.TRUE).apply(span); |
There was a problem hiding this comment.
Please replace the whole thing with span.end(throwable) - this is all handled already (see OpenTracingSpan.end(Throwable))
| /** | ||
| * Tag marking an Error. | ||
| */ | ||
| public static final TagSource<Boolean> ERROR = new BooleanTagSource("error"); |
There was a problem hiding this comment.
This tag does not belong here and should not be used (see comment above)
Signed-off-by: Dmitry Aleksandrov <dmitry.aleksandrov@oracle.com>
tomas-langer
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #7617 for Helidon 3