Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4x] [Doc] - Migration guides #7715

Merged
merged 15 commits into from
Oct 19, 2023
Merged

[4x] [Doc] - Migration guides #7715

merged 15 commits into from
Oct 19, 2023

Conversation

dalexandrov
Copy link
Contributor

Resolves #6487

@dalexandrov dalexandrov added docs 4.x Version 4.x labels Oct 4, 2023
@dalexandrov dalexandrov requested a review from ljamen October 4, 2023 14:15
@dalexandrov dalexandrov self-assigned this Oct 4, 2023
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Oct 4, 2023
@ljamen ljamen requested a review from barchetta October 4, 2023 15:05
barchetta
barchetta reviewed Oct 5, 2023
View reviewed changes
docs/about/introduction.adoc Outdated Show resolved Hide resolved
docs/about/introduction.adoc Outdated Show resolved Hide resolved
docs/mp/guides/migration_4x.adoc Outdated Show resolved Hide resolved
docs/mp/guides/migration_4x.adoc Outdated Show resolved Hide resolved
docs/mp/guides/migration_4x.adoc Outdated Show resolved Hide resolved
docs/se/guides/migration_4x.adoc Outdated Show resolved Hide resolved
docs/se/guides/migration_4x.adoc Outdated Show resolved Hide resolved
docs/se/guides/migration_4x.adoc Outdated Show resolved Hide resolved
docs/se/guides/migration_4x.adoc Outdated Show resolved Hide resolved
docs/se/guides/migration_4x.adoc Outdated Show resolved Hide resolved
@dalexandrov dalexandrov marked this pull request as draft October 5, 2023 08:58
ljamen
ljamen reviewed Oct 9, 2023
View reviewed changes
Copy link
Contributor

@ljamen ljamen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Completed review. Please let me know when all of Joe's comments are incorporated and I'll do a final review.

@ljamen ljamen requested a review from Verdent October 11, 2023 13:46
@dalexandrov dalexandrov marked this pull request as ready for review October 17, 2023 09:05
ljamen
ljamen previously approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@ljamen ljamen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

docs/mp/guides/migration_4x.adoc Outdated Show resolved Hide resolved
docs/se/guides/migration_4x.adoc Outdated Show resolved Hide resolved
docs/se/guides/migration_4x.adoc Outdated Show resolved Hide resolved
docs/se/guides/migration_4x.adoc Outdated Show resolved Hide resolved
docs/se/guides/migration_4x.adoc Outdated Show resolved Hide resolved
docs/se/guides/migration_4x.adoc Outdated

Learn more about `HttpService` and `Routing` at xref:../webserver.adoc[Helidon SE WebServer]

=== Significant changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

docs/se/guides/migration_4x.adoc Outdated Show resolved Hide resolved
docs/se/guides/migration_4x.adoc Outdated Show resolved Hide resolved
docs/se/guides/migration_4x.adoc Outdated Show resolved Hide resolved
docs/mp/guides/migration_4x.adoc Outdated Show resolved Hide resolved
@ljamen ljamen dismissed their stale review October 17, 2023 13:29

not yet approved

@ljamen ljamen mentioned this pull request Oct 17, 2023
Closed
16 tasks
ljamen
ljamen reviewed Oct 18, 2023
View reviewed changes
Copy link
Contributor

@ljamen ljamen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

most comments have been addressed. Please check with David on the security changes.

docs/mp/guides/migration_4x.adoc Outdated Show resolved Hide resolved
docs/se/guides/migration_4x.adoc Outdated Show resolved Hide resolved
docs/se/guides/migration_4x.adoc Outdated Show resolved Hide resolved
docs/mp/guides/upgrade_4x.adoc
NOTE: Please, read each specification carefully for incompatible changes!

=== Significant changes

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this where a new Security section would be added and David's info could be placed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

docs/se/guides/upgrade_4x.adoc Show resolved Hide resolved
dalexandrov and others added 14 commits October 19, 2023 17:05
@dalexandrov
Migration guide 4. Initial commit.
d7737d6 
Signed-off-by: Dmitry Aleksandrov <dmitry.aleksandrov@oracle.com>
@dalexandrov
Migration guide 4. Next steps.
45e9131 
Signed-off-by: Dmitry Aleksandrov <dmitry.aleksandrov@oracle.com>
@dalexandrov
Extend Helidon SE migration doc.
1844465 
Signed-off-by: Dmitry Aleksandrov <dmitry.aleksandrov@oracle.com>
@dalexandrov
Extend migration docs
d3df9c0 
Signed-off-by: Dmitry Aleksandrov <dmitry.aleksandrov@oracle.com>
@dalexandrov
Minor fixes
d5f28e8 
Signed-off-by: Dmitry Aleksandrov <dmitry.aleksandrov@oracle.com>
@dalexandrov
Extend documentation
ad52d8a 
Signed-off-by: Dmitry Aleksandrov <dmitry.aleksandrov@oracle.com>
@dalexandrov
Minor fixes
0896d73 
Signed-off-by: Dmitry Aleksandrov <dmitry.aleksandrov@oracle.com>
@ljamen @dalexandrov
DOCS: 4x updates to the general doc (helidon-io#7673)
374fd4b 
* updates to the general doc

* updates for 4x migrations
@dalexandrov
Migration guide 4. Initial commit.
3a516c6 
Signed-off-by: Dmitry Aleksandrov <dmitry.aleksandrov@oracle.com>
@dalexandrov
Add Global Config
1e83381 
Signed-off-by: Dmitry Aleksandrov <dmitry.aleksandrov@oracle.com>
@dalexandrov
MP Guide fix
422254d 
Signed-off-by: Dmitry Aleksandrov <dmitry.aleksandrov@oracle.com>
@dalexandrov
Add to sitegen
e6af959 
Signed-off-by: Dmitry Aleksandrov <dmitry.aleksandrov@oracle.com>
@dalexandrov
Migrate to upgrade
cdc0443 
Signed-off-by: Dmitry Aleksandrov <dmitry.aleksandrov@oracle.com>
@dalexandrov
Copyright fix
42c4852 
Signed-off-by: Dmitry Aleksandrov <dmitry.aleksandrov@oracle.com>
@dalexandrov
Add security changed modules
c33b9df 
Signed-off-by: Dmitry Aleksandrov <dmitry.aleksandrov@oracle.com>
ljamen
ljamen approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@ljamen ljamen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes incorporated.

@ljamen ljamen merged commit a39edbe into helidon-io:main Oct 19, 2023
12 checks passed
@dalexandrov dalexandrov deleted the 4x-migration-doc branch October 19, 2023 15:15
@ljamen ljamen mentioned this pull request Oct 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barchetta barchetta barchetta left review comments

@ljamen ljamen ljamen approved these changes

@Verdent Verdent Awaiting requested review from Verdent

Assignees

@dalexandrov dalexandrov

Labels
4.x Version 4.x docs OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dalexandrov @barchetta @ljamen