Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.x] Upgrades Hibernate to version 6.3.1.Final #7742

Merged

Conversation

ljnelson
Copy link
Member

@ljnelson ljnelson commented Oct 6, 2023

This PR upgrades Hibernate to verison 6.3.1.Final and adjusts certain hibernate.properties files found in integration tests to comply with Hibernate's ongoing series of settings removals.

Documentation impact: Hibernate 6.3.x has (somewhat oddly) removed support for the none bytecode provider, so any instances that end users have of hibernate.properties must remove any lines that resemble the following:

hibernate.bytecode.provider=none

This may have an impact on native image.

More specifics: the none bytecode provider still exists, but throws an exception when its "reflection optimizer" is accessed. There used to be a guard in the Hibernate source code that would not attempt to access the reflection optimizer if the none bytecode provider was selected, but that guard was removed, so any use of the none bytecode provider will result in an exception.

@ljnelson ljnelson added dependencies Pull requests that update a dependency file 4.x Version 4.x labels Oct 6, 2023
@ljnelson ljnelson requested a review from barchetta October 6, 2023 16:57
@ljnelson ljnelson self-assigned this Oct 6, 2023
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Oct 6, 2023
@ljnelson
Copy link
Member Author

ljnelson commented Oct 6, 2023

Hibernate 6.2.7 changes the way column ordering is performed so I will have to change all the various tests etc. to specify columns in their DDL.

@ljnelson ljnelson marked this pull request as draft October 6, 2023 18:18
@ljnelson ljnelson marked this pull request as ready for review October 6, 2023 18:30
@tvallin
Copy link
Member

tvallin commented Oct 8, 2023

See #7448

Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
…neration

Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
…edback

Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
@ljnelson ljnelson force-pushed the 4.x-upgrade-hibernate-to-6.3.1.Final branch from c3652d9 to 07e9ee4 Compare October 9, 2023 16:22
…cations/mp/pom.xml

Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
Copy link
Member

@barchetta barchetta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@barchetta barchetta linked an issue Oct 10, 2023 that may be closed by this pull request
@ljnelson ljnelson merged commit 1ab2791 into helidon-io:main Oct 10, 2023
12 checks passed
dalexandrov pushed a commit to dalexandrov/helidon that referenced this pull request Oct 17, 2023
* Upgrades Hibernate to version 6.3.1.Final

Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x Version 4.x dependencies Pull requests that update a dependency file OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4.x: Update Hibernate version from 6.1.7 to 6.3.X
3 participants