Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Microstream 08.01.01-MS-GA and other minor things #7752

Merged

Conversation

hrstoyanov
Copy link
Contributor

@hrstoyanov hrstoyanov commented Oct 8, 2023

Closes #7399.

@barchetta @hg-ms
Please consider this Microstream 08.01.01-MS-GA (latest official release) upgrade to Helidon 4.

Summary of changes:

  • Enforced Java 17 Microstream enhancements.
  • Could not re-write 1 test case , commented it out. Maybe @hg-ms can take a look at it.
  • Fixed other small useful things for this extension that IntelliJ found.

I was able to run the test cases.

@oracle-contributor-agreement
Copy link

Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
The following contributors of this PR have not signed the OCA:

To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.

When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.

If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. label Oct 8, 2023
@hrstoyanov hrstoyanov mentioned this pull request Oct 8, 2023
@hrstoyanov
Copy link
Contributor Author

I signed the Contributor Agreement. Jeez .. hire more developers Oracle, not lawyers!

@oracle-contributor-agreement
Copy link

Thank you for signing the OCA.

@oracle-contributor-agreement oracle-contributor-agreement bot added OCA Verified All contributors have signed the Oracle Contributor Agreement. and removed OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. labels Oct 9, 2023
@barchetta
Copy link
Member

@hrstoyanov thank you for your contribution! We will review.

Copy link
Member

@barchetta barchetta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See copyright check for a list of files that need the copyright updated. And thanks for your contribution and patience with our lawyers!

dependencies/pom.xml Outdated Show resolved Hide resolved
integrations/microstream/cache/pom.xml Outdated Show resolved Hide resolved
@hrstoyanov
Copy link
Contributor Author

@barchetta , I just committed the requested changes, let me know if you have further requests.
@hg-ms last chance to review before this gets merged!

Copy link
Member

@tjquinno tjquinno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are several files where you have changed only the copyright date. We avoid that if we can, although sometimes it's necessary if a file was changed, pushed, and then the change reverted.

@barchetta
Copy link
Member

@hrstoyanov one more copyright fix needed. Almost there!

@tvallin
Copy link
Member

tvallin commented Oct 10, 2023

The PR should not contain file where copyright are changed and no other changes were made to the file.
I understand the copyright check is failing and the reason is what @tjquinno explained during is review. To fix that, you can squash your commits and force-push. In this way, you will pass the copyright check without updating copyright to unchanged files.

Copy link
Member

@barchetta barchetta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Many thanks.

@barchetta barchetta merged commit 24d2734 into helidon-io:main Oct 10, 2023
12 checks passed
@hrstoyanov
Copy link
Contributor Author

@fh-ms - please review.

@hg-ms
Copy link
Contributor

hg-ms commented Oct 17, 2023

@hrstoyanov
FH is currently out of office, so I had a look at the merged PR.
I have no objections, the code looks fine.

Many thanks from the Microstream team for the version upgrade.
Best regards.

@hrstoyanov hrstoyanov deleted the 7339-upgrade-microstream-for-helidon4 branch October 17, 2023 05:50
dalexandrov pushed a commit to dalexandrov/helidon that referenced this pull request Oct 17, 2023
…-io#7752)

* Upgrade to Microstream 08.01.01-MS-GA and other minor things
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants