-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Microstream 08.01.01-MS-GA and other minor things #7752
Upgrade to Microstream 08.01.01-MS-GA and other minor things #7752
Conversation
Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application. When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated. If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public. |
I signed the Contributor Agreement. Jeez .. hire more developers Oracle, not lawyers! |
Thank you for signing the OCA. |
@hrstoyanov thank you for your contribution! We will review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See copyright check for a list of files that need the copyright updated. And thanks for your contribution and patience with our lawyers!
@barchetta , I just committed the requested changes, let me know if you have further requests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are several files where you have changed only the copyright date. We avoid that if we can, although sometimes it's necessary if a file was changed, pushed, and then the change reverted.
...ics/src/main/java/io/helidon/integrations/microstream/metrics/MicrostreamMetricsSupport.java
Outdated
Show resolved
Hide resolved
@hrstoyanov one more copyright fix needed. Almost there! |
The PR should not contain file where copyright are changed and no other changes were made to the file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Many thanks.
@fh-ms - please review. |
@hrstoyanov Many thanks from the Microstream team for the version upgrade. |
…-io#7752) * Upgrade to Microstream 08.01.01-MS-GA and other minor things
Closes #7399.
@barchetta @hg-ms
Please consider this Microstream 08.01.01-MS-GA (latest official release) upgrade to Helidon 4.
Summary of changes:
I was able to run the test cases.