Reinstate exemplar support #7760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjquinno
requested review from
ljnelson,
spericas,
barchetta,
tomas-langer and
arjav-desai
oracle-contributor-agreement
bot
added
the
OCA Verified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #7721
In 3.x, Helidon metrics implemented exemplars itself.
In 4.x, we rely on the exemplar support in the Micrometer Prometheus meter registry. We "simply" need to provide a way to obtain the span and trace identification when the Prometheus meter registry wants it, which we do using
Contextswhich, if tracing is present, contains the span context.I also revised the example which shows exemplar support slightly to re-enable a disabled test (after fixing a few problems).
Users do nothing different to enable exemplar support; the details are all in our code.
Documentation
Updates are part of this PR.