Support for longer WebSocket frames #8025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
spericas
added
webserver
websocket
oracle-contributor-agreement
bot
added
the
OCA Verified
danielkec
reviewed
Nov 17, 2023
webserver/websocket/src/main/java/io/helidon/webserver/websocket/WsConnection.java
Outdated
Show resolved
Hide resolved
danielkec
reviewed
Nov 17, 2023
webserver/websocket/src/main/java/io/helidon/webserver/websocket/WsConnection.java
Outdated
Show resolved
Hide resolved
1. Support for writing WS frames of more than 125 bytes, i.e. with lengths that fit in two bytes and eight bytes. 2. Configuration of max-frame-length to limit the size of a frame read by the server. The JDK WS client splits a long payload into 16K frames. 3. Some new tests for (1) and (2).
danielkec
previously approved these changes
Nov 20, 2023
…classpath. Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
tomas-langer
approved these changes
Nov 20, 2023
| .config() | ||
| .protocols() | ||
| .stream() | ||
| .filter(p -> p instanceof WsConfig) |
There was a problem hiding this comment.
You could work around the ugly cast by doing (after filter)
.map(WsConfig.class::cast)
which will change the stream to correctly typed one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to issue #7986.
Documentation
JavaDoc has been updated.