Headers on server cannot be set after entity was sent #8042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…am was requested (throws IllegalStateException) Content length is removed from headers before being sent if expecting chunked encoding in HTTP/1.1 Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
oracle-contributor-agreement
bot
added
the
OCA Verified
romain-grecourt
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
, or output stream was requested (throws IllegalStateException)
Content length is removed from headers before being sent if expecting chunked encoding in HTTP/1.1
Resolves #8003
Description
Usability fix.
The methods now throw
IllegalStateExceptionwhen an attempt is done to do something that is wrong.This may cause errors in existing code, where the problem was silently ignored and the headers were never set. As this is a bugfix, this behavior change is needed.
Updated javadoc of
header(Header)method onServerResponseto declare the exception