Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add proper handling of content-read and content-write logs within HTTP Request tracing span #8105

Merged
merged 2 commits into from
Dec 7, 2023
Merged

Add proper handling of content-read and content-write logs within HTTP Request tracing span #8105

merged 2 commits into from
Dec 7, 2023

Conversation

tjquinno
Copy link
Member

@tjquinno tjquinno commented Dec 6, 2023 •
edited
Loading

Description

Resolves #8103

  1. Before adding the content-write log to the HTTP Request span, the TracingObserver code did not check to see if content-write was enabled or not.
  2. TracingObserver did not deal with content-read at all.
  3. There was a formatting problem on the tracing doc page.

Documentation

This is a bug fix. No doc changes (except for correcting the formatting problem).

@tjquinno tjquinno self-assigned this Dec 6, 2023
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Dec 6, 2023
@tjquinno tjquinno marked this pull request as draft December 6, 2023 02:07
@tjquinno tjquinno marked this pull request as ready for review December 6, 2023 15:30
@tjquinno tjquinno requested a review from ljamen December 6, 2023 15:45
dalexandrov
dalexandrov previously approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@dalexandrov dalexandrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

dalexandrov
dalexandrov approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@dalexandrov dalexandrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great

@tjquinno tjquinno merged commit 7092015 into helidon-io:main Dec 7, 2023
12 checks passed
@tjquinno tjquinno deleted the 4.x-content-write branch December 7, 2023 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalexandrov dalexandrov dalexandrov approved these changes

@romain-grecourt romain-grecourt Awaiting requested review from romain-grecourt

@tomas-langer tomas-langer Awaiting requested review from tomas-langer

@ljamen ljamen Awaiting requested review from ljamen

Assignees

@tjquinno tjquinno

Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[4.x] - Tracing issues
2 participants
@tjquinno @dalexandrov