Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.x Add missing metrics to Pokemons example #8129

Merged
merged 2 commits into from
Dec 11, 2023

Conversation

tvallin
Copy link
Member

@tvallin tvallin commented Dec 11, 2023

Description

fix #7955 + typo into examples/cors/pom.xml

Note: a follow up issue was opened : #8117

Documentation

no impact

Signed-off-by: tvallin <thibault.vallin@oracle.com>
@tvallin tvallin requested a review from tjquinno December 11, 2023 09:31
@tvallin tvallin self-assigned this Dec 11, 2023
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Dec 11, 2023
Copy link
Member

@tjquinno tjquinno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One change. Thanks.

examples/integrations/cdi/pokemons/pom.xml Outdated Show resolved Hide resolved
Signed-off-by: tvallin <thibault.vallin@oracle.com>
@tvallin tvallin merged commit 0c4e5a0 into helidon-io:main Dec 11, 2023
12 checks passed
@tvallin tvallin deleted the pokemon-metrics branch December 11, 2023 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x Version 4.x examples metrics OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4.x Pokemons example start-up logs that it cannot find MP metrics MetricRegistry class; missing metrics?
2 participants