4.x Allow programmatic look-up of MetricRegistry via CDI without NPE #8210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tim Quinn <tim.quinn@oracle.com>
oracle-contributor-agreement
bot
added
the
OCA Verified
spericas
reviewed
Jan 8, 2024
microprofile/metrics/src/test/java/io/helidon/microprofile/metrics/ProducerTest.java
Outdated
Show resolved
Hide resolved
spericas
reviewed
Jan 8, 2024
microprofile/metrics/src/main/java/io/helidon/microprofile/metrics/RegistryProducer.java
Outdated
Show resolved
Hide resolved
spericas
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #8209
The producer method failed to check that the injection point and its
getAnnotated()return value were non-null before using them. ThusCDI.current().select(MetricRegistry.class).get()triggered an NPE.(It turned out that the
InjectionPointpassed is non-null but itsgetAnnotated()return value was null in this case.)Documentation
Bug fix - no doc impact