Upgrades Oracle database libraries to version 21.9.0.0. Adds tests under datasource-ucp CDI integration. #8221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljnelson
added
P3
dependencies
oracle-contributor-agreement
bot
added
the
OCA Verified
tjquinno
previously approved these changes
Jan 11, 2024
barchetta
reviewed
Jan 11, 2024
There was a problem hiding this comment.
What about the other areas that ojdbc8-production is used?
./integrations/db/ojdbc/pom.xml: <artifactId>ojdbc8-production</artifactId>
./examples/employee-app/pom.xml: <artifactId>ojdbc8-production</artifactId>
./examples/integrations/oci/atp/pom.xml: <artifactId>ojdbc8-production</artifactId>
./examples/integrations/oci/atp-cdi/pom.xml: <artifactId>ojdbc8-production</artifactId>
./examples/integrations/cdi/datasource-hikaricp/pom.xml: <artifactId>ojdbc8-production</artifactId>
./messaging/connectors/aq/pom.xml: <artifactId>ojdbc8-production</artifactId>
Sure, I'll take care of those. |
ljnelson
force-pushed
the
autocommit-explorations-0
branch
from
ed675c7 to
5ec685b
Compare
…er datasource-ucp CDI integration. Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
…base Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
ljnelson
force-pushed
the
autocommit-explorations-0
branch
from
5ec685b to
ed0fba3
Compare
arjav-desai
reviewed
Feb 14, 2024
| @@ -127,7 +127,8 @@ | |||
| <version.lib.neo4j>5.12.0</version.lib.neo4j> | |||
| <version.lib.netty>4.1.100.Final</version.lib.netty> | |||
| <version.lib.oci>3.34.0</version.lib.oci> | |||
| <version.lib.ojdbc8>21.4.0.0</version.lib.ojdbc8> | |||
| <version.lib.ojdbc>21.9.0.0</version.lib.ojdbc> | |||
| <version.lib.ojdbc8>${version.lib.ojdbc}</version.lib.ojdbc8> | |||
There was a problem hiding this comment.
Are we keeping this property for backward compatibility or should we remove it?
There was a problem hiding this comment.
My assumption has always been that if there is a property defined in a pom.xml somewhere that appears in the inheritance chain of, say, applications/mp/pom.xml, which this one does, then it probably should obey the rules of semantic versioning, so should stick around, in this case, until Helidon 5. Maybe others have opinions.
|
Hmm; might also need to decipher https://www.oracle.com/database/technologies/appdev/jdbc-downloads.html |
arjav-desai
previously approved these changes
Feb 14, 2024
Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
ljnelson
changed the title
arjav-desai
previously approved these changes
Feb 14, 2024
|
Hmm; UCP is dying: |
…s the highest version that can be used that does not throw NullPointerExceptions in certain cases; adds test to catch this problem Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
ljnelson
changed the title
|
The A workaround, should it become necessary, is to invoke the |
Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
arjav-desai
approved these changes
Feb 15, 2024
hrstoyanov
pushed a commit
to hrstoyanov/helidon
that referenced
this pull request
Feb 23, 2024
…der datasource-ucp CDI integration. (helidon-io#8221) Upgrades Oracle database libraries to version 21.9.0.0. Adds test under datasource-ucp CDI integration. Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Oracle database library versions to 21.9.0.0.
Versions of the Universal Connection Pool higher than this can throw
NullPointerExceptions if a non-Oracle driver is used (such as H2's). One of the tests this PR adds checks for this problem explicitly to catch it early should an accidental upgrade beyond 21.9.0.0 occur in the future.This PR also ensures that we are using the
ojdbc11family of artifacts, at least in thedatasource-ucpCDI integration, which are the ones that should be used with JDK 11+ (or 21, which is the base of Helidon 4). See https://www.oracle.com/database/technologies/appdev/jdbc-downloads.html for more information.It also adds a test resulting from a very lengthy internal discussion that shows that the Universal Connection Pool does not do anything to reset any underlying connection state when a borrowed connection is checked out, modified, and returned to the pool. This is useful information going forward and we want this test to fail/alert us if UCP addresses this shortcoming in any way.