Remove clear-out of registries from extension; do it in TCK-only shutdown observer; update doc #8292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…down observer; update doc Signed-off-by: Tim Quinn <tim.quinn@oracle.com>
oracle-contributor-agreement
bot
added
the
OCA Verified
hrstoyanov
pushed a commit
to hrstoyanov/helidon
that referenced
this pull request
Feb 23, 2024
…down observer; update doc (helidon-io#8292) Signed-off-by: Tim Quinn <tim.quinn@oracle.com>
tvallin
pushed a commit
to tvallin/helidon
that referenced
this pull request
Feb 28, 2024
…down observer; update doc (helidon-io#8292) Signed-off-by: Tim Quinn <tim.quinn@oracle.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #8287
(mostly a forward-port of PR #6956. See that PR for more info)
Early in Helidon 3 the metrics CDI extension cleared out the application
MetricRegistrylate in its initialization. This was primarily to allow TCK tests, which start up the container repeatedly, to work. (Some of the TCK tests reuse the same metric name for different metric types; if the registry was not cleared out between TCK tests the second attempt to register the same-named metric would fail.)Later in Helidon 3 (but after the code base for 4 had been started), we changed this so a TCK-only CDI extension did the clean-out and we removed that code from the 3.x metrics CDI extension.
This PR does basically the same thing but in the Helidon 4 codebase. The PR also adds some doc comments (copied from the 3.x PR) warning users against registering metrics from their own CDI extensions until after the metrics extension has run and initialized metrics using the correct configuration.
Documentation
PR includes doc changes.