-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes a few problems handling character encodings in URIs #8327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
All contributors have signed the Oracle Contributor Agreement.
label
Feb 2, 2024
spericas
force-pushed
the
issue-8232-2
branch
from
February 2, 2024 14:56
dd32527
to
12d55f5
Compare
spericas
force-pushed
the
issue-8232-2
branch
from
February 2, 2024 15:47
12d55f5
to
63d8ffa
Compare
tjquinno
previously approved these changes
Feb 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Does this PR fully resolve the referenced issue? If so, maybe link them directly. If not maybe add a checklist of sub-problems to the issue and link PRs to the checklist?
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
…n ClientUri query string. Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
spericas
force-pushed
the
issue-8232-2
branch
from
February 5, 2024 18:39
63d8ffa
to
9c697bb
Compare
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
tjquinno
approved these changes
Feb 5, 2024
hrstoyanov
pushed a commit
to hrstoyanov/helidon
that referenced
this pull request
Feb 23, 2024
…#8327) * Fixes problems converting a ClientUri to a URI. Improved test. Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com> * Drops skip encoding setting in connector after fixing handling of + in ClientUri query string. Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com> * Trying using forkCount set to 1. Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com> --------- Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
tvallin
pushed a commit
to tvallin/helidon
that referenced
this pull request
Feb 28, 2024
…#8327) * Fixes problems converting a ClientUri to a URI. Improved test. Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com> * Drops skip encoding setting in connector after fixing handling of + in ClientUri query string. Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com> * Trying using forkCount set to 1. Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com> --------- Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
4.x
Version 4.x
jersey
OCA Verified
All contributors have signed the Oracle Contributor Agreement.
rest-client
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a few problems handling character encodings in URIs. Namely,
See #8326.