Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes a few problems handling character encodings in URIs #8327

Merged
merged 3 commits into from
Feb 5, 2024

Conversation

spericas
Copy link
Member

@spericas spericas commented Feb 2, 2024

Description

Fixes a few problems handling character encodings in URIs. Namely,

  1. Handles "+" in query strings as introduced by Jersey (MP Rest Client)
  2. Drops the skip encoding in the Helidon Connector (no longer needed)
  3. Adds a few more tests that verify these changes

See #8326.

@spericas spericas added this to the 4.0.5 milestone Feb 2, 2024
@spericas spericas requested a review from tjquinno February 2, 2024 14:55
@spericas spericas self-assigned this Feb 2, 2024
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Feb 2, 2024
tjquinno
tjquinno previously approved these changes Feb 2, 2024
Copy link
Member

@tjquinno tjquinno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Does this PR fully resolve the referenced issue? If so, maybe link them directly. If not maybe add a checklist of sub-problems to the issue and link PRs to the checklist?

Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
…n ClientUri query string.

Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
@spericas spericas merged commit 1cf9272 into helidon-io:main Feb 5, 2024
12 checks passed
hrstoyanov pushed a commit to hrstoyanov/helidon that referenced this pull request Feb 23, 2024
…#8327)

* Fixes problems converting a ClientUri to a URI. Improved test.

Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>

* Drops skip encoding setting in connector after fixing handling of + in ClientUri query string.

Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>

* Trying using forkCount set to 1.

Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>

---------

Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
tvallin pushed a commit to tvallin/helidon that referenced this pull request Feb 28, 2024
…#8327)

* Fixes problems converting a ClientUri to a URI. Improved test.

Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>

* Drops skip encoding setting in connector after fixing handling of + in ClientUri query string.

Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>

* Trying using forkCount set to 1.

Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>

---------

Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x Version 4.x jersey OCA Verified All contributors have signed the Oracle Contributor Agreement. rest-client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants