Fix for #8344 - Incorrect SQL Type for null Parameters in JDBC Parameter Binding #8342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR addresses an issue in the JDBC parameter binding logic where null values were incorrectly being set with Types.VARCHAR SQL type. This behavior could lead to SQL exceptions when inserting null into non-VARCHAR columns in a database. The proposed change ensures that null values are set with Types.NULL, allowing the JDBC driver to correctly interpret the intended type based on the column definition. Problem Description: When attempting to insert null values into a database using the Helidon JDBC client, the fixed SQL type of Types.VARCHAR for null parameters leads to type mismatch errors for columns of types other than VARCHAR. For example, inserting null into a NUMERIC column results in a PSQLException with a message indicating a type mismatch. Proposed Solution: The fix involves changing the SQL type for null parameters from Types.VARCHAR to Types.NULL in the setParameter method of the JDBC parameter handling logic. This change allows the JDBC driver to determine the correct type for the null value based on the context of the column it is being inserted into, thus preventing type mismatch errors.
|
Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application. When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated. If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public. |
oracle-contributor-agreement
bot
added
the
OCA Required
bjcoombs
changed the title
|
fix for #8344 |
Update copyright
|
Thank you for signing the OCA. |
oracle-contributor-agreement
bot
added
OCA Verified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR addresses an issue in the JDBC parameter binding logic where
nullvalues were incorrectly being set withTypes.VARCHARSQL type. This behavior lead to SQL exceptions when insertingnullinto non-VARCHARcolumns in a database. The proposed change ensures thatnullvalues are set withTypes.NULL, allowing the JDBC driver to correctly interpret the intended type based on the column definition.Problem Description:
When attempting to insert
nullvalues into a database using the Helidon JDBC client, the fixed SQL type ofTypes.VARCHARfornullparameters leads to type mismatch errors for columns of types other thanVARCHAR. For example, insertingnullinto aNUMERICcolumn results in aPSQLExceptionwith a message indicating a type mismatch.Proposed Solution:
The fix involves changing the SQL type for
nullparameters fromTypes.VARCHARtoTypes.NULLin thesetParametermethod of the JDBC parameter handling logic. This change allows the JDBC driver to determine the correct type for thenullvalue based on the context of the column it is being inserted into, thus preventing type mismatch errors.