Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for sending websocket CLOSE frames without a payload #8408

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

spericas
Copy link
Member

@spericas spericas commented Feb 22, 2024

Description

Adds support for sending CLOSE frames without a payload as required by the spec. Updates tests to verify use case. See issue #8407.

Documentation

None

@spericas spericas self-assigned this Feb 22, 2024
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Feb 22, 2024
@spericas spericas marked this pull request as draft February 22, 2024 22:04
…y spec. Updates tests to verify use case. See issue 8407.
@spericas spericas added this to the 4.0.6 milestone Feb 23, 2024
@spericas spericas marked this pull request as ready for review February 23, 2024 13:40
@romain-grecourt romain-grecourt linked an issue Feb 23, 2024 that may be closed by this pull request
@spericas spericas merged commit cde5595 into helidon-io:main Feb 26, 2024
12 checks passed
hrstoyanov pushed a commit to hrstoyanov/helidon that referenced this pull request Mar 12, 2024
…y spec. Updates tests to verify use case. See issue 8407. (helidon-io#8408)
hrstoyanov pushed a commit to hrstoyanov/helidon that referenced this pull request Mar 12, 2024
…y spec. Updates tests to verify use case. See issue 8407. (helidon-io#8408)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

WebSocket does not close if status code is missing.
3 participants