[4.x] security review for archetypes #8445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
...rchetype/mp/common/files/src/main/resources/META-INF/microprofile-config.properties.mustache
Outdated
Show resolved
Hide resolved
| @@ -318,7 +318,7 @@ docker run --rm --name mysql -p 3306:3306 \ | |||
| <value key="jdbcDataSource">com.mysql.cj.jdbc.MysqlDataSource</value> | |||
| <value key="databaseUrl">jdbc:mysql://127.0.0.1:3306/pokemon?useSSL=false</value> | |||
| <value key="dbUser">user</value> | |||
| <value key="userPassword">password</value> | |||
| <value key="userPassword">changeit</value> | |||
There was a problem hiding this comment.
See the comment about {{userPassword}} above.
There was a problem hiding this comment.
regarding the previous case I agree - fixed. Here, hovewer, the variable name is userPassword and the value is password which was changed to changeit. So, should be correct.
tvallin
reviewed
Mar 1, 2024
Signed-off-by: Maxim Nesen <maxim.nesen@oracle.com>
tvallin
approved these changes
Mar 4, 2024
romain-grecourt
approved these changes
Mar 4, 2024
|
@senivam This needs to be backported to 3.x |
|
@romain-grecourt ok, will do |
hrstoyanov
pushed a commit
to hrstoyanov/helidon
that referenced
this pull request
Mar 12, 2024
Signed-off-by: Maxim Nesen <maxim.nesen@oracle.com>
hrstoyanov
pushed a commit
to hrstoyanov/helidon
that referenced
this pull request
Mar 12, 2024
Signed-off-by: Maxim Nesen <maxim.nesen@oracle.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
aligning passwords used in archetypes with security requirements.