-
Notifications
You must be signed in to change notification settings - Fork 580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.x: Upgrade checkout to v4, setup-java to v4.1.0 #8447
2.x: Upgrade checkout to v4, setup-java to v4.1.0 #8447
Conversation
For my local build of the PR everything works just fine:
|
The failing test is known to be unstable: #4323 |
why not to ignore it then? :D As I would say - no test no problem. The strange thing about it is that it was failing 3 times in a row on the same JDK and all the time with different outputs. |
To prove the issue is JDK related, I've done a tiny modification to your PR which is rolling back just one JDK version for the Helidon build: Basically, the version of the action is not important, it does not relate to JDK's version, but they've just updated the Temurine JDK to 11.0.22. And I have to roll it back to the 11.0.21. After I did this the build just had passed OK: Before the change it was failing in my local branch as well. The reference to the passing action is https://github.com/senivam/helidon/actions/runs/8146385385 |
The test is unstable due to a race condition so the changing of the JDK is likely altering timing. Looks like @danielkec fixed the race condition in 3.x but not 2.x. I've back ported the fix in #8453. Hopefully that resolves the problem! |
78f8743
to
1cd5199
Compare
Description
Upgrades GitHub actions:
See #8435
Documentation
No impact