Avoid implementing the OCI Monitoring interface. #8474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he one in OciMetricsBean.
oracle-contributor-agreement
bot
added
the
OCA Verified
ljnelson
reviewed
Mar 12, 2024
…oring interface. Additional Note: This fix also includes a resolution to helidon-io#7739 that is caused by the Monitoring.postMetricData() to be called before the test metrics are registered.
…cs on the 1st invocation of Monitoring.postMetricData
barchetta
approved these changes
Mar 19, 2024
romain-grecourt
pushed a commit
to hrstoyanov/helidon
that referenced
this pull request
Mar 19, 2024
…to to mock it. (helidon-io#8474) The goal of this test fix is to remove implementing Monitoring interface as a way to mock Monitoring client, as it is causing updates to be made if that interface has changed during an upgrade to OCI SDK is made. Instead, the OCIExtension is now mocked and inside of it, a mocked Monitoring bean using Proxy is injected. With this approach, there is no need to implement all the methods of Monitoring interface, but only mock those that are needed for the test.
klustria
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The test in io.helidon.integrations.oci.metrics.cdi uses an implemented OCI Monitoring class. When an OCI SDK upgrade is made and the Monitoring class has changed (for example, a new method is added or a method is removed or a method's signature has changed), this will lead to a need to update the implementation which is quite cumbersome. The goal of this change is to avoid that issue by using Proxy to mock only the Monitoring class methods that are required by the test. The issue was filed via #8377.
This change also includes a resolution to #7739 that is caused by the Monitoring.postMetricData() being called before the test metrics are registered.
Solutions
Documentation
No doc impact as this only affects the Unit Test.