Refactors JtaConnection to allow status enforcement by JTA implementation #8479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljnelson
added
enhancement
oracle-contributor-agreement
bot
added
the
OCA Verified
…is STATUS_MARKED_ROLLBACK Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
ljnelson
force-pushed
the
8441-jtaconnection-marked-for-update-0
branch
from
277e7fe to
6fdf12a
Compare
tjquinno
previously approved these changes
Jun 26, 2024
…tests Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
tjquinno
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors
JtaConnection(and makes requisite changes in other files to accommodate) so that if desired all enlistment validation can be performed by the JTA implementation, rather than proactively by the Helidon classes.This pull request is in response to #8441 but it is not clear that the desired use case is supportable. The refactorings help more cleanly separate responsibilities, however.
The refactorings are behind a system property for the moment (
helidon.jta.preemptiveEnlistmentChecks). To run an application with these refactorings in effect, passfalsefor this value (it istrueby default for backwards compatibility).Documentation impact: none; this is an internal refactoring only.