Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.x: Archetype - Implement MP JSON and metrics combination #8629

Merged
merged 2 commits into from
Apr 19, 2024

Conversation

tvallin
Copy link
Member

@tvallin tvallin commented Apr 8, 2024

Description

This PR:

  • Remove the nested output from the input metrics option
  • Split the metrics microprofile and micrometer output into separated file
  • Adapt the created metrics endpoint response type based on JSON selected
  • Fix a javadoc typo

fix #8536

Documentation

no impact

Signed-off-by: tvallin <thibault.vallin@oracle.com>
@tvallin tvallin added this to the 4.0.8 milestone Apr 8, 2024
@tvallin tvallin self-assigned this Apr 8, 2024
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Apr 8, 2024
romain-grecourt
romain-grecourt previously approved these changes Apr 8, 2024
Signed-off-by: tvallin <thibault.vallin@oracle.com>
@tvallin tvallin changed the title 4.x: Archetype - remove JSON media type when return a string that is not JSON 4.x: Archetype - Implement MP JSON and metrics combination Apr 11, 2024
@tvallin
Copy link
Member Author

tvallin commented Apr 18, 2024

@romain-grecourt you previously approved but don't you mind checking the review changes ?

@tvallin tvallin merged commit 205384b into helidon-io:main Apr 19, 2024
12 checks passed
@tvallin tvallin deleted the 4.x-archetype-json-string-8536 branch April 19, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x Version 4.x archetypes MP OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generated MP app SimpleGreetResource#getMessage method claims to produce JSON but returns String
3 participants