Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4.x: Add text block support #8655

Merged
merged 4 commits into from
May 2, 2024
Merged

4.x: Add text block support #8655

merged 4 commits into from
May 2, 2024

Conversation

jbescos
Copy link
Member

@jbescos jbescos commented Apr 12, 2024

Description

#7920

Documentation

None

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Apr 12, 2024
@jbescos jbescos marked this pull request as draft April 12, 2024 07:49
@jbescos jbescos force-pushed the issue7920 branch 2 times, most recently from 2dd798f to 5a5d991 Compare April 12, 2024 08:05
@jbescos jbescos self-assigned this Apr 12, 2024
@jbescos jbescos marked this pull request as ready for review April 12, 2024 08:05
@jbescos jbescos force-pushed the issue7920 branch 2 times, most recently from 5370bed to 47535a4 Compare April 15, 2024 07:16
@jbescos jbescos force-pushed the issue7920 branch 3 times, most recently from b6d2527 to cb870de Compare April 19, 2024 08:23
@tomas-langer
Copy link
Member

This looks really useful!

@jbescos jbescos requested a review from tomas-langer April 24, 2024 12:16
@jbescos jbescos force-pushed the issue7920 branch 3 times, most recently from f251774 to 8c59ebd Compare April 30, 2024 04:57
@jbescos
Copy link
Member Author

jbescos commented Apr 30, 2024

Examples fails missing artifact:

 Error:  Failed to execute goal org.xolstice.maven.plugins:protobuf-maven-plugin:0.6.1:compile (default) on project helidon-examples-webserver-protocols: Unable to resolve artifact: Missing:
Error:  ----------
Error:  1) com.google.protobuf:protoc:exe:osx-aarch_64:3.5.1-1
Error:  
Error:    Try downloading the file manually from the project website.
Error:  
Error:    Then, install it using the command: 
Error:        mvn install:install-file -DgroupId=com.google.protobuf -DartifactId=protoc -Dversion=3.5.1-1 -Dclassifier=osx-aarch_64 -Dpackaging=exe -Dfile=/path/to/file
Error:  
Error:    Alternatively, if you host your own repository you can deploy the file there: 
Error:        mvn deploy:deploy-file -DgroupId=com.google.protobuf -DartifactId=protoc -Dversion=3.5.1-1 -Dclassifier=osx-aarch_64 -Dpackaging=exe -Dfile=/path/to/file -Durl=[url] -DrepositoryId=[id]
Error:  
Error:    Path to dependency: 
Error:    	1) io.helidon.examples.webserver:helidon-examples-webserver-protocols:jar:4.0.0-SNAPSHOT
Error:    	2) com.google.protobuf:protoc:exe:osx-aarch_64:3.5.1-1

jbescos added 4 commits May 1, 2024 10:33
@jbescos @romain-grecourt
Add text block support
4e9ae2b 
Signed-off-by: Jorge Bescos Gascon <jorge.bescos.gascon@oracle.com>
@jbescos @romain-grecourt
Comment reviews about renamings
1377e16 
Signed-off-by: Jorge Bescos Gascon <jorge.bescos.gascon@oracle.com>
@jbescos @romain-grecourt
Modify type as string
c275fa7 
Signed-off-by: Jorge Bescos Gascon <jorge.bescos.gascon@oracle.com>
@jbescos @romain-grecourt
Rename tests
00d2950 
Signed-off-by: Jorge Bescos Gascon <jorge.bescos.gascon@oracle.com>
romain-grecourt
romain-grecourt approved these changes May 1, 2024
View reviewed changes
Copy link
Contributor

@romain-grecourt romain-grecourt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please file an issue to track the remaining work to support all config sources.

@jbescos jbescos merged commit 85f95d6 into helidon-io:main May 2, 2024
12 checks passed
@jbescos jbescos mentioned this pull request May 2, 2024
Closed
@jbescos
Copy link
Member Author

jbescos commented May 2, 2024 •
edited
Loading

LGTM, please file an issue to track the remaining work to support all config sources.

Thanks, here it is: #8718

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielkec danielkec danielkec left review comments

@romain-grecourt romain-grecourt romain-grecourt approved these changes

@tomas-langer tomas-langer Awaiting requested review from tomas-langer

Assignees

@jbescos jbescos

Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jbescos @tomas-langer @danielkec @romain-grecourt