Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.x: Use LevelChangePropagator in examples/logging/slf4j (#7737) #8656

Merged
merged 2 commits into from
May 2, 2024

Conversation

Captain1653
Copy link
Contributor

@Captain1653 Captain1653 commented Apr 12, 2024

Description

References #7737

Thoughts:

  1. I'm not sure, but it can be something like that. I've added org.slf4j:jul-to-slf4j, because it wasn't in the dependencies. I think, that it should be done.
  2. It's little hard to understand, how to confirm, that the performance cost was mitigated :).

Questions:

  1. I didn't add debug="true", because it wasn't added before. Should I add it?
  2. Should I do the same things for logback-aot module? I think yes, but I can be wrong.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Apr 12, 2024
Copy link
Contributor

@romain-grecourt romain-grecourt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say we want debug="true" as that us a short-hand for a best practice.
logback-aot should also be updated however you will need to triple check that it works well with native image.

examples/logging/slf4j/src/main/resources/logback.xml Outdated Show resolved Hide resolved
@Captain1653
Copy link
Contributor Author

I've found the "issue" with checkstyle.

Locally it doesn't check the rule NewlineAtEndOfFile, but CI does. Maybe I missed something.

CI locally

I checked the checkstyle.xml and there is this rule.

@romain-grecourt romain-grecourt merged commit a5c30ee into helidon-io:main May 2, 2024
12 checks passed
@Captain1653 Captain1653 deleted the 7737-jul-mdc branch May 2, 2024 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants