[4.x] LazyConfigSource is now queried when an unknown node is requested #8707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
tomas-langer
changed the title
danielkec
previously approved these changes
Apr 30, 2024
config/config/src/main/java/io/helidon/config/ProviderImpl.java
Outdated
Show resolved
Hide resolved
…the user, instead of being ignored.
…Map, as computeIfAbsent should not be used for possibly blocking operations (which we need).
tomas-langer
force-pushed
the
7745-lazy-config
branch
from
08bb3ae to
cafdf25
Compare
|
Rebased on current |
danielkec
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously
LazyConfigSourcewas invoked only for nodes that existed in other config sources. If a node was not known by the config system, it would always return an empty value, even if one of the lazy config sources could provide a value for it.This PR introduces a change where we first check if the key exists in any lazy source before caching it as non-existent.
As usual with Helidon Config, changes in time are not reflected, as the config tree is considered a snapshot of configuration (even though the lazy config source may introduce a value later in time, it is still considered immutable, and changes must be handled through change API).
Resolves #8709
Documentation
We are currently missing documentation of
LazyConfigSourceand I did not add it as part of this PR.