Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.x: Upgrade to MP Config 3.1 and fix an issue with profile specific properties #8757

Merged
merged 10 commits into from
May 29, 2024

Conversation

barchetta
Copy link
Member

@barchetta barchetta commented May 13, 2024

Description

  1. Upgrade MicroProfile Config to version 3.1
  2. Fix an issue (4.x: MP Config does not correctly handling per property overriding with config profiles #8738) with profile specific property precedence that was found by a new TCK test
  3. Return a well-formed ConfigValue even when value is an unresolved expression (required by new TCK tests)
  4. Add unit tests for the above issues

Fixes #8724
Fixes #8738

Documentation

Updated with new MP Config version.

Compatibility

MP Config 3.1 is fully backwards compatible with MP Config 3.0. But the bug fixes in this PR do alter the behavior of our implementation which potentially could impact a small set of users if they were depending on the buggy behavior. For this reason we should do this upgrade in 4.1 instead of 4.0.9.

@barchetta barchetta added MP config dependencies Pull requests that update a dependency file 4.x Version 4.x labels May 13, 2024
@barchetta barchetta added this to the 4.1.0 milestone May 13, 2024
@barchetta barchetta self-assigned this May 13, 2024
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label May 13, 2024
@barchetta barchetta marked this pull request as ready for review May 14, 2024 17:33
@barchetta barchetta merged commit d0d7c64 into helidon-io:main May 29, 2024
12 checks passed
@barchetta barchetta deleted the 4.x-mp-config-3.1 branch November 12, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x Version 4.x config dependencies Pull requests that update a dependency file MP OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
2 participants