Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to gRPC server-side support #8765

Merged
merged 6 commits into from
May 28, 2024
Merged

Improvements to gRPC server-side support #8765

merged 6 commits into from
May 28, 2024

Conversation

spericas
Copy link
Member

@spericas spericas commented May 15, 2024 •
edited
Loading

Description

Several improvements to GrpcProtocolHandler:

  • support for flow control/back-pressure, data can now be queued if listener is not able to process it fast enough
  • better handling for headers/trailers between gRPC and HTTP/2
  • support for compression and codec negotiation
  • additional tests

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label May 15, 2024
@spericas spericas marked this pull request as draft May 15, 2024 18:24
@spericas spericas self-assigned this May 15, 2024
@spericas spericas added this to the 4.x milestone May 15, 2024
@spericas spericas changed the title Improvements to gRPC server-side support [draft] Improvements to gRPC server-side support May 15, 2024
@spericas spericas marked this pull request as ready for review May 23, 2024 13:24
@spericas spericas changed the title [draft] Improvements to gRPC server-side support Improvements to gRPC server-side support May 23, 2024
@spericas spericas requested a review from tomas-langer May 28, 2024 13:15
tomas-langer
tomas-langer reviewed May 28, 2024
View reviewed changes
Copy link
Member

@tomas-langer tomas-langer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small formal issues, otherwise looks good.

webserver/grpc/src/main/java/io/helidon/webserver/grpc/GrpcProtocolHandler.java Outdated Show resolved Hide resolved
webserver/grpc/src/main/java/io/helidon/webserver/grpc/GrpcProtocolHandler.java Outdated Show resolved Hide resolved
@spericas spericas requested a review from tomas-langer May 28, 2024 13:35
@spericas spericas merged commit 2525b39 into helidon-io:main May 28, 2024
12 checks passed
@spericas spericas mentioned this pull request May 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomas-langer tomas-langer tomas-langer approved these changes

Assignees

@spericas spericas

Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
4.x
Development

Successfully merging this pull request may close these issues.
2 participants
@spericas @tomas-langer