Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4.x: Mocking documentation #8787

Merged
merged 4 commits into from
Jun 5, 2024
Merged

4.x: Mocking documentation #8787

merged 4 commits into from
Jun 5, 2024

Conversation

tvallin
Copy link
Member

@tvallin tvallin commented May 22, 2024 •
edited
Loading

Description

Add documentation about CDI based mocking documentation:

  • Introduce new doc package named testing that gather testing snippet and related *.adoc.
  • New code snippets.
  • New mock section in testing.adoc.

fix #8339
fix #8772

Documentation

Updated into this PR

@tvallin tvallin self-assigned this May 22, 2024
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label May 22, 2024
@tvallin tvallin added this to the 4.0.9 milestone May 22, 2024
romain-grecourt
romain-grecourt reviewed May 22, 2024
View reviewed changes
Copy link
Contributor

@romain-grecourt romain-grecourt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this fit with #8772 ?

docs/src/main/asciidoc/mp/testing.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/mp/testing.adoc Outdated Show resolved Hide resolved
@tvallin
Copy link
Member Author

tvallin commented May 24, 2024

I see it as 2 chapters under Mock Support where the first one would be helidon mocking support and the second mocking support with CDI.

@romain-grecourt
Copy link
Contributor

I see it as 2 chapters under Mock Support where the first one would be helidon mocking support and the second mocking support with CDI.

Can you reflect this in your changes ?
I.e. the section title and the snippet class name.

@barchetta barchetta modified the milestones: 4.0.9, 4.1.0 May 28, 2024
@barchetta
Copy link
Member

This PR should not be merged until the fix for #8772 is merged to ensure that both of these go into a release together.

@tvallin tvallin changed the title 4.x: CDI based mocking documentation 4.x: Mocking documentation Jun 3, 2024
tvallin added 4 commits June 4, 2024 08:59
@tvallin
Mock documentation
97829b2 
Signed-off-by: tvallin <thibault.vallin@oracle.com>
@tvallin
review changes
da8231f 
Signed-off-by: tvallin <thibault.vallin@oracle.com>
@tvallin
Update doc layer and review comments
40b5dac 
Signed-off-by: tvallin <thibault.vallin@oracle.com>
@tvallin
Helidon mock documentation
6ecc7ac 
Signed-off-by: tvallin <thibault.vallin@oracle.com>
@tvallin tvallin force-pushed the mock-documentation branch from 6ac5fd5 to 6ecc7ac Compare June 4, 2024 07:00
@barchetta barchetta requested a review from romain-grecourt June 5, 2024 16:12
@romain-grecourt romain-grecourt merged commit abba8b5 into helidon-io:main Jun 5, 2024
12 checks passed
@tvallin tvallin deleted the mock-documentation branch June 6, 2024 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romain-grecourt romain-grecourt romain-grecourt approved these changes

@barchetta barchetta Awaiting requested review from barchetta

Assignees

@tvallin tvallin

Labels
4.x Version 4.x docs MP OCA Verified All contributors have signed the Oracle Contributor Agreement. testing
Projects
None yet
Milestone
4.1.0
Development

Successfully merging this pull request may close these issues.

4.x: Document @MockBean unit tests 4.x: Document CDI based mocking for unit tests
3 participants
@tvallin @romain-grecourt @barchetta