Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.x: forward port of serial-config fix #8814

Merged
merged 4 commits into from
May 31, 2024

Conversation

barchetta
Copy link
Member

Description

Forward port of #7116 to 4.x to fix #7007 and #7000

Updates existing serial-config.properties file for our ojdbc driver integration module to support jep-290 out-of-box
Make sure all helidon modules, archetypes and examples use this integration/ojdbc module
Update doc to specify integration/ojdbc module usage instead of direct driver usage

Documentation

Updated as part of this PR

@barchetta barchetta added integration 4.x Version 4.x labels May 29, 2024
@barchetta barchetta self-assigned this May 29, 2024
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label May 29, 2024
ljnelson
ljnelson previously approved these changes May 30, 2024
Copy link
Member

@ljnelson ljnelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM although I haven't kept up to speed super recently with all the naming changes in Oracle database artifact land

arjav-desai and others added 4 commits May 30, 2024 12:25
@barchetta barchetta force-pushed the 4.x-serial-config-port branch from 8cd7b67 to 20e7f02 Compare May 30, 2024 19:29
@barchetta barchetta modified the milestone: 4.0.10 May 30, 2024
Copy link
Member

@arjav-desai arjav-desai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@barchetta barchetta merged commit ef6649f into helidon-io:main May 31, 2024
12 checks passed
@barchetta barchetta deleted the 4.x-serial-config-port branch November 12, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x Version 4.x integration OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Fix serial-config.properties for io.helidon.integrations.db:ojdbc and ensure consistent use
4 participants