-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
4.x: forward port of serial-config fix #8814
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
All contributors have signed the Oracle Contributor Agreement.
label
May 29, 2024
barchetta
requested review from
ljnelson,
romain-grecourt,
arjav-desai and
danielkec
May 30, 2024 00:06
ljnelson
previously approved these changes
May 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM although I haven't kept up to speed super recently with all the naming changes in Oracle database artifact land
tvallin
requested changes
May 30, 2024
archetypes/archetypes/src/main/archetype/mp/custom/database-outputs.xml
Outdated
Show resolved
Hide resolved
tvallin
approved these changes
May 30, 2024
* fix serial config for oracle driver for jep-290 * fix dep name * remove ucp from dep since hikari is used
barchetta
force-pushed
the
4.x-serial-config-port
branch
from
May 30, 2024 19:29
8cd7b67
to
20e7f02
Compare
arjav-desai
approved these changes
May 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
4.x
Version 4.x
integration
OCA Verified
All contributors have signed the Oracle Contributor Agreement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Forward port of #7116 to 4.x to fix #7007 and #7000
Updates existing serial-config.properties file for our ojdbc driver integration module to support jep-290 out-of-box
Make sure all helidon modules, archetypes and examples use this integration/ojdbc module
Update doc to specify integration/ojdbc module usage instead of direct driver usage
Documentation
Updated as part of this PR